Exposing simple UI action to open next segment of a heap dump #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
matthiasblaesing,
neilcsmith-net and
sdedic
JaroslavTulach
commented
Jan 27, 2022
| @@ -28,16 +28,19 @@ | |||
| */ | |||
| class CacheDirectory { | |||
|
|
|||
| private static final String DIR_EXT = ".hwcache"; // NOI18N | |||
| private static final String DIR_EXT = ".nbcache"; // NOI18N | |||
There was a problem hiding this comment.
This change is useful to avoid clash between Apache NetBeans profiler library and VisualVM profiler library. Both of these libraries are derived from NetBeans 8.2 profiler library, but evolve independently. Sharing the same directory leads to errors like:
java.io.IOException: Invalid HPROF version 3 loaded 2
at ...HprofHeap.<init>(HprofHeap.java)
at ...HeapFactory.loadHeap(HeapFactory.java)
at ...HeapFactory.createHeap(HeapFactory.java)
neilcsmith-net
approved these changes
Jan 27, 2022
matthiasblaesing
approved these changes
Jan 27, 2022
|
The Profiler native binary build-windows is repeatedly failing. Do you think it can be because of my changes? I have renamed the cached directory - that is the only (yet unlikely) thing which could cause the profiler binaries failures. |
|
Looks like it might have been failing for a while. It's only triggered rarely by path. Just done a manual trigger on master. And fails there too https://github.com/apache/netbeans/actions/runs/1762385602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a simple library to generate
.hproffiles: HeapDump. It follows the Java Profiler Heap Dump Format specification, however it allows more than regular JVMs do. Regular JVMs always dump the whole heap in a single round, while the HeapDump allows one to generate multiple segments.There already is support for reading these multisegment files in the Apache NetBeans Profiler library - it just isn't exposed in the heapwalker UI. This PR fixes that. The fix isn't "fancy", but it does its job. When an additional segment is detected, there is a little link in the UI to open it in a new window.
Simple, but functional. I'd be delighted if the support for multisegment
.hproffiles landed in the NetBeans 13.