Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup a bunch of raw type error messages related to TreeSet. #4582

Merged
merged 2 commits into from
Sep 4, 2022

Conversation

BradWalker
Copy link
Member

Cleanup a bunch of raw type error messages related to TreeSet. Issues like these..

[repeat] /home/bwalker/src/netbeans/enterprise/web.core.syntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java:512: warning: [unchecked] unchecked call to addAll(Collection<? extends E>) as a member of the raw type TreeSet
[repeat] ts.addAll(mapper.keySet());
[repeat] ^
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class TreeSet


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

lkishalmi and others added 2 commits September 4, 2022 13:59
* Fix Gradle resourche watchers not attached on project open

* Hide empty generated source dirs

* Move the SourceGroup filtering to the UI

Cleanup a bunch of raw type error msgs related to TreeSet.
Issues like these..

[repeat] /home/bwalker/src/netbeans/enterprise/web.core.syntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java:512: warning: [unchecked] unchecked call to addAll(Collection<? extends E>) as a member of the raw type TreeSet
[repeat] ts.addAll(mapper.keySet());
[repeat] ^
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class TreeSet
@BradWalker
Copy link
Member Author

BradWalker commented Sep 4, 2022

This code has already been reviewed in pull request #4555 . I had some problems with getting the Git history correct. So I created a new branch and merged my changes into it. To keep everything clean.

Like I said, it's ready to merge. Just need to pass checks..

@BradWalker BradWalker self-assigned this Sep 4, 2022
@BradWalker BradWalker added this to the NB16 milestone Sep 4, 2022
@BradWalker BradWalker merged commit 5c4f116 into apache:master Sep 4, 2022
@BradWalker BradWalker deleted the cleanup_raw_type_treeset branch September 6, 2022 16:48
Chris2011 pushed a commit to Chris2011/netbeans that referenced this pull request Dec 15, 2022
…e#4582)

Cleanup a bunch of raw type error messages related to TreeSet..

Issues like these..

[repeat] /home/bwalker/src/netbeans/enterprise/web.core.syntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java:512: warning: [unchecked] unchecked call to addAll(Collection<? extends E>) as a member of the raw type TreeSet
[repeat] ts.addAll(mapper.keySet());
[repeat] ^
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class TreeSet

Co-authored-by: Laszlo Kishalmi <laszlo.kishalmi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants