-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: the final migration #4817
CI: the final migration #4817
Conversation
Well, this puts a timescale of end of year on all this - https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=Travis+Migrations |
yes I saw the mail too. Good that we started so early - the hardest part is done :) |
2d97d86
to
e322852
Compare
630d030
to
451a7ca
Compare
e573caa
to
697a43f
Compare
@matthiasblaesing I noticed that you are sometimes providing dev builds for your PRs to make it easier to review. I added a label activated dev build step which can do the same ( a test run is here (scroll down): retention time is set to 7 days. Its a zip in a zip but this is currently a github limitation. |
@neilcsmith-net @ebarboni (or anybody else) edit: sorry made a typo and pinged Eirik by accident. Hello Eirik :) @neilcsmith-net I added the build-from-platform-source-zip job as step to platform batch1 job I am going to try to enable caching with the next update so that the build won't download dependencies again. |
- configure fallback JDK 11 for the gradle daemon - the Gradle daemon currently doesn't want to run on JDK 19+. Interestingly, the NB build works fine locally. This issue only occurred on the CI runner
6b75995
to
677eb86
Compare
- mac runners have ant installed, brew/cache isn't needed anymore. - added cache for platform-src build - bump JDK version of migrated jobs to 11 where possible - extract java distribution variable - increase pipeline artifact retention time from 1 to 2 days - added per-job timeouts (at least 2x of average runtime; 1h minimum) - always run the paperwork job - set continue-on-error for java.mx.project false in PRs - wrapped platform/core.startup, java/java.editor, java.lsp.server in retry script - ci:dev-build will now produce a dev-build zip artifact - setup all JDKs at the start of the job for consistent timestamp
677eb86
to
040a042
Compare
LSP job sometimes errors with:
but the retry script can brute force through it - so its all good. Thanks to @sdedic for fixing the nb-javac task issue in #4975 (#4921 for context). I also changed all jobs which use multiple JDKs to set them up right at the beginning of the job for getting consistent timestamps of JDK tools. |
@neilcsmith-net @lkishalmi @ebarboni @sdedic would now be a good time to merge this? Is most of the release work done? I also see master is green again.. so this might be good timing. Reminder that travis will be gone in less than a month. We should have CI working before that so that we can fix things if needed. |
I would say go for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @ebarboni - let's go! Also, while we're not doing branch protection on checks, a reminder on list that from now on CI should be expected to be green before merging wouldn't be amiss.
Thanks for all your work on this!
continuesfinishes the great migration (#4431).new labels to control jobs with:
Groovy
runs the groovy jobGraalVM
runs the GraalVM job - should this trigger on other labels too?LSP
runs the LSP (server) job, client is currently tested via the IDE jobVSCode Extension
runs the VSCode jobtests
enables a step which builds all tests, this will only run on PRs, not on the master branchHarness job runs with the
Platform
label - haven't found a better place to put it.Each commit usually migrates a single job to make review easier.
The last commit adds some general improvements:
platform/core.startup
,java/java.editor
andjava.lsp.server
in retry scriptci:dev-build
will now produce a dev-build zip artifactNB can now also build on JDK 19: