Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test bugfixes: preparation for GH action migration #4975

Merged
merged 8 commits into from
Nov 23, 2022

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Nov 16, 2022

A follow-up to #4921.

The most important fix is a fix to nbjavac task that prevents classes like $JsCallback$ and similar to be deleted just before an incremental compilation because they are considered inner classes (without a matching outer class).

I've added additional logging to both server and client, because some thrown errors are wrapped into uninformative "Internal error". Added possibility to log-trace LSP messages (enabled by System property)

I've cleaned up the test a little:

  • the exception about missing Groovy support turned into a WARNING line, if the client demands Groovy enabled, but it is simply not available. Other Reflective exceptions show stacktrace.
  • fixed error that manifested by a print about 'not normalized' license template filename/path
  • suppressed SocketClosed exceptions in test output
  • fixed potential CNFE when running on JDK11: Truffle could not access sun.misc.Unsafe during script engine initialization

@sdedic sdedic added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests Platform [ci] enable platform tests (platform/*) build labels Nov 16, 2022
@sdedic sdedic added this to the NB17 milestone Nov 16, 2022
@sdedic sdedic self-assigned this Nov 16, 2022
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Appreciate the fixes to the exception logging too - this makes it easier to find issues in the log when something happens.

<condition property="test.bootclasspath.prepend.args" value="--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming,jdk.jdi">
<condition property="test.bootclasspath.prepend.args" value="--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming,jdk.jdi,jdk.unsupported">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent! This means we have another job which could run on JDK 11+ (e.g in a matrix).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really - there are still some failing tests, I asked @dbalek for an assistance as the failure seems to be deeply burried in javac binding infrastructure. But it's definitely a step forward.

@mbien mbien mentioned this pull request Nov 18, 2022
@mbien
Copy link
Member

mbien commented Nov 21, 2022

lets merge this this week so that we can finish up the migration PR and open it for review. Travis will end free support for open source projects, apache projects have to migrate before the end of this year.

@sdedic sdedic merged commit 23b4c52 into apache:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests Platform [ci] enable platform tests (platform/*)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants