-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize Scala class constructor #4901
Recognize Scala class constructor #4901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version increment commit will need removing if intended for delivery.
This probably won't be reviewed in time for rc3, so will need a call whether this change needs to trigger an rc4, otherwise it won't make it in unless something else does.
@mbien is a label required to trigger that test?
@neilcsmith-net however |
@neilcsmith-net I temp enabled them in #4817. We will see |
f6e3301
to
b82a123
Compare
This is a low priority bugfix PR. No need for special RC. Integrate, if you have a chance. If not let's merge to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtulach Will be kept in mind if we have an rc4.
many tests fail, so we can't turn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I am developing mixed Java+Scala application with the NetBeans IDE. I got debugging working, but I have problems to place a breakpoint on constructor of some classes. This is the (disassembled) source I see in the editor:
I can place a method breakpoint on it (as the triangle in the left editor gutter indicates). However the breakpoint is then later reported as misplaced.
I tracked this down to problems in recognizing constructor of such strangely named Scala classes like:
org.enso.compiler.core.IR$Name$MethodReference
. This PR extracts the "constructor recognizing logic" into its own method and adds few tests to verify current behavior. Then it adds a test and a fix to make the code work for my usage case 3205d10.