Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize Scala class constructor #4901

Merged

Conversation

jtulach
Copy link
Contributor

@jtulach jtulach commented Nov 2, 2022

I am developing mixed Java+Scala application with the NetBeans IDE. I got debugging working, but I have problems to place a breakpoint on constructor of some classes. This is the (disassembled) source I see in the editor:
image
I can place a method breakpoint on it (as the triangle in the left editor gutter indicates). However the breakpoint is then later reported as misplaced.

I tracked this down to problems in recognizing constructor of such strangely named Scala classes like: org.enso.compiler.core.IR$Name$MethodReference. This PR extracts the "constructor recognizing logic" into its own method and adds few tests to verify current behavior. Then it adds a test and a fix to make the code work for my usage case 3205d10.

@jtulach jtulach added this to the NB16 milestone Nov 2, 2022
@jtulach jtulach self-assigned this Nov 2, 2022
Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version increment commit will need removing if intended for delivery.

This probably won't be reviewed in time for rc3, so will need a call whether this change needs to trigger an rc4, otherwise it won't make it in unless something else does.

@mbien is a label required to trigger that test?

java/debugger.jpda/nbproject/project.properties Outdated Show resolved Hide resolved
@mbien
Copy link
Member

mbien commented Nov 2, 2022

@neilcsmith-net java/debugger.jpda.<foo> are in the "Java Modules" job which is always on since its a short job
https://github.com/apache/netbeans/actions/runs/3374691868/jobs/5607816502

however java/debugger.jpda tests are commented out. When I migrated I left everything commented out which was already commented out on travis.

@mbien
Copy link
Member

mbien commented Nov 2, 2022

@neilcsmith-net I temp enabled them in #4817. We will see in about 30mins once done if the tests still work. Will update this comment with results.

@jtulach jtulach force-pushed the jtulach/RecognizeScalaConstructor branch from f6e3301 to b82a123 Compare November 2, 2022 16:50
@jtulach
Copy link
Contributor Author

jtulach commented Nov 2, 2022

This probably won't be reviewed in time for rc3, so will need a call whether this change needs to trigger an rc4

This is a low priority bugfix PR. No need for special RC. Integrate, if you have a chance. If not let's merge to master.

Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtulach Will be kept in mind if we have an rc4.

@neilcsmith-net neilcsmith-net dismissed their stale review November 2, 2022 17:12

Version change fixed.

@mbien
Copy link
Member

mbien commented Nov 2, 2022

many tests fail, so we can't turn java/debugger.jpda on right now:
https://github.com/apache/netbeans/actions/runs/3379257947/jobs/5611704286

Copy link
Contributor

@entlicher entlicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@neilcsmith-net neilcsmith-net merged commit 04440c8 into apache:delivery Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants