Fixing pattern matching for binding patterns #5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng pattern. Originally provided as: apache#3342 Manually ported to current state of (nb)javac. Closes: apache#3342
matthiasblaesing
added
Java
- JavaHintsAnnotationProcessorTest makes assumptions about the error messages. On non-english locales this fails, so ensure an english locale is configured. - Elements#getPackageElement in modular projects is to specific as it suppresses results where an empty package is found. To work around this fallback to Elements#getAllPackageElements, which misses this check. - The golden analyser pattern in UtilitiesTest needs to be adjusted to reality: The $expr is reported twice: once as JCConstantLabel and once as JCIdent
matthiasblaesing
force-pushed
the
hints_instanceof
branch
from
a04a6cf
to
56d4ab4
Compare
matthiasblaesing
requested review from
mbien and
jlahoda
and removed request for
mbien
|
@jlahoda this is an updated version of your PR #3342. The fix was pending and began to bitrot. As I think I triggered it and it was already reviewed by @jtulach I had a look and checked if I could fix the problems. I think I succeeded. Could you please double check? @mbien you touched the tests so would be nice if you could also have a look. |
jlahoda
approved these changes
Dec 20, 2022
mbien
approved these changes
Dec 20, 2022
Comment on lines
-383
to
-385
| assertPositions(result, positions[0], code, "$expr", "$stmts$", "$stmts$;", "case $expr: foo bar $stmts$;", "foo", "foo bar "); | ||
| assertPositions(result, positions[0], code, "$expr", "$expr", "$stmts$", "$stmts$;", "case $expr: foo bar $stmts$;", "foo", "foo bar "); | ||
| } | ||
| */ |
There was a problem hiding this comment.
awesome. Good to see this test case enabled.
I wanted to do that in:
#5107 (comment)
when we enabled tests for this module (and many others) which was completely turned off till now.
but I wasn't sure if the result was actually correct. So I commented it out instead of running the risk to commit a wrong test assumption.
|
Thank you for the review. Lets get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.