enable some important sounding java tests #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
commented
Dec 13, 2022
Comment on lines
+369
to
370
| /* TODO: fails | ||
| public void testCasePattern() throws Exception { |
There was a problem hiding this comment.
this one failed with:
Testcase: testCasePattern(org.netbeans.modules.java.hints.spiimpl.UtilitiesTest): FAILED
expected:
<[$expr, $stmts$, $stmts$;, case $expr: foo bar $stmts$;, foo, foo bar ]>
but was:
<[$expr, $expr, $stmts$, $stmts$;, case $expr: foo bar $stmts$;, foo, foo bar ]>
junit.framework.AssertionFailedError: expected:<[$expr, $stmts$, $stmts$;, case $expr: foo bar $stmts$;, foo, foo bar ]> but was:<[$expr, $expr, $stmts$, $stmts$;, case $expr: foo bar $stmts$;, foo, foo bar ]>
at org.netbeans.modules.java.hints.spiimpl.UtilitiesTest.assertPositions(UtilitiesTest.java:660)
at org.netbeans.modules.java.hints.spiimpl.UtilitiesTest.testCasePattern(UtilitiesTest.java:382)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:77)
at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:476)
at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:402)
at java.base/java.lang.Thread.run(Thread.java:1589)
mbien
force-pushed
the
enable-more-tests
branch
from
d8d6ce9
to
a27a0f2
Compare
mbien
force-pushed
the
enable-more-tests
branch
2 times, most recently
from
5f9367e
to
54b2446
Compare
mbien
force-pushed
the
enable-more-tests
branch
from
54b2446
to
1d78ffe
Compare
mbien
commented
Dec 14, 2022
- java/maven.hints - java.lexer - spi.java.hints - refactoring.java - form - javadoc - junit some tests needed to be excluded due to failures or missing test data. PR review showed that JavaTokenDumpTest can be repaired by adding a look-ahead to the string literal test data.
mbien
force-pushed
the
enable-more-tests
branch
from
1d78ffe
to
c1ec0da
Compare
matthiasblaesing
approved these changes
Dec 18, 2022
This was referenced Dec 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this required to disable some tests in
java.lexer,javadocand a single test case inspi.java.hints. Everything else worked fine when run directly from the IDE with JDK 19. Lets see what CI says.