Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add retry script to ide/options.editor tests and increase mac timeout. #5254

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 9, 2023

checked the CI runs of the last 18 merges to master to see if we can reduce the whack-a-mole factor a bit.

Most had java.mx.project failing which is already wrapped in a retry script and continue-on-erroris set to true for merges. I couldn't reproduce the failure locally, it always passed, so this one might be tricky to fix (previews attempt #4100).

But ide/options.editor did also fail often. Those are fairly short tests which could benefit from a retry script - which I added with this PR.

I did also increase the job timeout on mac since the mac runners can sometimes have really high latencies or artifact download speeds.

The other tests failing were in java/refactoring.java and java.source.base which would be mitigated by #5138 if it makes it in before freeze.

@mbien mbien added the CI Continuous Integration label Jan 9, 2023
@mbien mbien added this to the NB17 milestone Jan 9, 2023
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. If this is not enough, we might need to mask a subset of test with @RandomlyFails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants