PHP 8.0 Support: Attribute Syntax (Part 4) #6929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmysik
reviewed
Jan 9, 2024
php/php.editor/src/org/netbeans/modules/php/editor/elements/IndexQueryImpl.java
Outdated
Show resolved
Hide resolved
tmysik
approved these changes
Jan 9, 2024
|
@tmysik Thank you for your review and your time! I'll merge this after I remove the unused methods :) |
- apache#4300 - https://wiki.php.net/rfc/attributes_v2 - https://wiki.php.net/rfc/shorter_attribute_syntax - https://wiki.php.net/rfc/shorter_attribute_syntax_change - Fix the code completion feature - Index classess marked as the Attribute(`#[\Attribute]`) - Add/Fix unit tests for the indexer and the code completion - Increment the spec version Note: The following case is not fixed yet. ```php #[MyAttr(self::^CONST1)] // don't work here yet class Example { public const CONST1 = 1; } ```
junichi11
force-pushed
the
php-gh-4300-attribute-cc
branch
from
f88db83
to
4b4b377
Compare
|
@junichi11 No need to thank me, you did all the work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[\Attribute])Note: The following case is not fixed yet.