New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 Support: Attribute Syntax (Part 4) #6929

Merged

junichi11 merged 1 commit into apache:master from junichi11:php-gh-4300-attribute-cc

Jan 9, 2024

Commits on Jan 9, 2024

PHP 8.0 Support: Attribute Syntax (Part 4)

- apache#4300
- https://wiki.php.net/rfc/attributes_v2
- https://wiki.php.net/rfc/shorter_attribute_syntax
- https://wiki.php.net/rfc/shorter_attribute_syntax_change
- Fix the code completion feature
- Index classess marked as the Attribute(`#[\Attribute]`)
- Add/Fix unit tests for the indexer and the code completion
- Increment the spec version

Note: The following case is not fixed yet.
```php
 #[MyAttr(self::^CONST1)] // don't work here yet
 class Example {
     public const CONST1 = 1;
 }
```

junichi11 committed Jan 9, 2024