-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some static code analyzer warnings #7284
Fixed some static code analyzer warnings #7284
Conversation
netbeans/java/form/src/org/netbeans/modules/form/layoutdesign/LayoutFeeder.java Lines 3892 to 3901 in b2dffef
L3897 likely has to be |
all tests green, got one timeout in the maven tests which is already tracked via #7263, the micronaut test step needed a restart too but those are known to be unreliable. |
b2dffef
to
093064a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me!
ide/csl.api/src/org/netbeans/modules/csl/editor/completion/MethodParamsTipPaintComponent.java
Outdated
Show resolved
Hide resolved
java/java.editor/src/org/netbeans/modules/editor/java/MethodParamsTipPaintComponent.java
Outdated
Show resolved
Hide resolved
- one occurence was in dead code
- incorrect getHeight() method was never called
093064a
to
8da11fc
Compare
removed the two unused |
LGTM do ready to merge ? |
yes should be ready |
fixed some endless recursion, NPE and comparison issues. One commit per category.
edit: PR was inspired by this blog post but contains a few more changes
targets delivery