Declarative hint editor support fixes and improvements #7333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
mbien
force-pushed
the
jackpot-fixes-and-improvements_delivery
branch
from
18dc23e
to
0b58f60
Compare
|
todo for future: changing the source level default to (reverted the change) |
There was a problem hiding this comment.
Please add an entry to java/java.hints/licenseinfo.xml for the file, with the license.
There was a problem hiding this comment.
it is the icon for jnlp / applets. It was already in NB. I don't know the license.
There was a problem hiding this comment.
My take on this is, that the file was donated by Oracle to the ASF. I don't see why Oracle would not be in a position to donate that file, so it is ALv2.
There was a problem hiding this comment.
done, also mentioned in the commit that it is a copy of applet.gif
.../java.hints.declarative/src/org/netbeans/modules/java/hints/declarative/test/TestParser.java
Show resolved
Hide resolved
...nts.declarative/src/org/netbeans/modules/java/hints/declarative/DeclarativeHintRegistry.java
Outdated
Show resolved
Hide resolved
mbien
force-pushed
the
jackpot-fixes-and-improvements_delivery
branch
from
0b58f60
to
3ecce48
Compare
- register hint file templates and descriptions - add file icon (copy of applet.gif) - add template for hint tests
- source-level option does now understand the new java version scheme - optional %% token allows marking the end of a test - register run-single action to hint file editor - log file parsing errors
mbien
force-pushed
the
jackpot-fixes-and-improvements_delivery
branch
from
3ecce48
to
4d97642
Compare
matthiasblaesing
approved these changes
Apr 28, 2024
lahodaj
reviewed
Apr 29, 2024
|
this seems to degrade CV test stability. It is hard to say if it makes it worse just by bad luck (timing) or if there is something wrong with the hint editor support. failures seem to be on linux only and they can be brute forced till green. exception looks like: |
|
lets see if its just the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted some fixes and improvement from a cleanup branch, would be cool if we could get this into NB 22 still.
jackpot hint support improvements
source-leveloption does now understand the "new" java version schemeuse reasonable source level defaultreverted since tests failed%%token allows marking the end of a testupdate declarative hint templates
demonstrates usecase for
%%(without it, there couldn't be any space between test cases):file templates:
file icons:
run file action in editor:
hint template:
the hint test template matches to the hint template: