-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CV: skip sporadically failing template delivery #7344
CV: skip sporadically failing template delivery #7344
Conversation
so the CV tests on linux passed on first attempt, which is a good sign (esp when compared to https://github.com/apache/netbeans/actions/runs/8876164558).
|
- failure: "FSException: Cannot get shared access" - tests can be brute forced into passing. - It is not clear if something is wrong with the hint editor support or if this template is just degrading the sporadically failing tests further due to changed timing. lets try to skip over it and check if it improves the stability. other: - wrap masterfs.macosx in retry script due to sporadic failures in OSXNotifierTest#testNextEvent
1238704
to
fa58699
Compare
9949cf7
to
a8dd303
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course a fix for the root cause of the instability would be preferred, but not causing false-positives is more important.
In general this looks like a good cleanup. Thank you!
platform/openide.util.ui/test/unit/src/org/openide/util/test/TestFileUtils.java
Outdated
Show resolved
Hide resolved
a8dd303
to
4aae710
Compare
- "Cannot delete file" isn't very useful, Files#delete will state the cause if available - might help to debug some sporadic test failures - global refactoring to replace similar patterns resulted in some TestUtil/TestFileUtils cleanup which was duplicated everywhere
4aae710
to
cbd9644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
#7333 degrades CV test stability
lets try to skip over it and check if it improves the stability.
other:
masterfs.macosx
in retry script due to sporadic failures inOSXNotifierTest#testNextEvent
NbTestCase
: useFiles#delete
for better exception on failure, (second commit)Files#delete
will state the cause if availableTestUtil
cleanup which was duplicated everywhere