Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bundled maven to 3.9.8. #7468

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Update bundled maven to 3.9.8. #7468

merged 1 commit into from
Jun 18, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Jun 13, 2024 •
edited
Loading

@mbien mbien added do not merge Don't merge this PR, it is not ready or just demonstration purposes. Upgrade Library Library (Dependency) Upgrade Maven [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jun 13, 2024
@mbien mbien added this to the NB23 milestone Jun 13, 2024
@mbien mbien mentioned this pull request Jun 13, 2024
Closed
@mbien

This comment was marked as off-topic.

Sign in to view
@mbien mbien mentioned this pull request Jun 13, 2024
Closed
@MartinBalin MartinBalin mentioned this pull request Jun 14, 2024
Closed
@MartinBalin

This comment was marked as off-topic.

Sign in to view
@MartinBalin

This comment was marked as off-topic.

Sign in to view
@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jun 17, 2024
@mbien mbien marked this pull request as ready for review June 17, 2024 20:22
@mbien
Copy link
Member Author

mbien commented Jun 17, 2024 •
edited
Loading

switched to release version and refreshed PR

ran some manual tests and everything seemed fine, after that I selected mvnd 1.0 (which uses mvn 3.9.8 too) and repeated the tests and things went fine too.

matthiasblaesing
matthiasblaesing approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks sane to me and quick(!) smoke test ran clean. Thank you.

@mbien mbien merged commit 2821184 into apache:master Jun 18, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@lkishalmi lkishalmi Awaiting requested review from lkishalmi

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Maven [ci] enable "build tools" tests Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Milestone
NB23
Development

Successfully merging this pull request may close these issues.

Move from maven 3.9.7 to 3.9.8
3 participants
@mbien @MartinBalin @matthiasblaesing