MINIFICPP-595: Provide basic support for windows. #394
Conversation
phrocker
force-pushed
the
windows
branch
3 times, most recently
from
5b571b2
to
538b3ee
Compare
|
reviewing |
There was a problem hiding this comment.
hey @phrocker,
I've been looking over this a fair bit and got it to work. I opened the directory in Visual Studio 2017 15.8.4. Looking at the CMakeSettings.json, I used the x64-Debug configuration as that seemed to capture the caveats for the initial support and had things disabled. I also could not get a successful build without installing OpenSSL from https://slproweb.com/products/Win32OpenSSL.html. Is this anticipated?
Overall looks and has been working well with the scope for the initial effort. Super awesome. I'll poke around a bit more but just wanted to give some initial feedback.
CMakeSettings.json
Outdated
| // See https://go.microsoft.com//fwlink//?linkid=834763 for more information about this file. | ||
| "configurations": [ | ||
| { | ||
| "name": "x86-Debug", |
There was a problem hiding this comment.
Should we remove these other configurations (those besides x64-Debug) until they are functional?
| @@ -1427,3 +1451,183 @@ This product bundles 'bsdiff' which is available under a "2-clause BSD" license. | |||
| STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING | |||
| IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | |||
| POSSIBILITY OF SUCH DAMAGE. | |||
|
|
|||
| This product bundles 'Simple-Windows-Posix-Semaphore' which is available under an Apache v2 License. | |||
There was a problem hiding this comment.
As this is ALv2 it shouldn't be needed in the LICENSE. There does not appear to be a NOTICE which would have to get incorporated.
There was a problem hiding this comment.
I always felt this was good hygiene as a practice. Further I always thought that Category A licenses needed to adhere to the attribution portion of the aforementioned license. 4.d of http://apache.org/licenses/LICENSE-2.0 led me to believe this is a smart inclusion. I assume there is other language that makes this recursive attribution assumed?
There was a problem hiding this comment.
The guidance from ASF is here http://www.apache.org/dev/licensing-howto.html#alv2-dep. To your point, and in light of the ASF guidance, I believe we could just list the project and its version omitting the full license text?
There was a problem hiding this comment.
@apiri I added this very early on into the branch and thought I only had the first line ( also coincidentally only saw this in your comment ). Yes, totally agree that all of that text below the project and version is completely unnecessary. thanks!
|
@apiri it is not anticipated that OpenSSL be installed for this release. Will check. Thanks! |
phrocker
force-pushed
the
windows
branch
2 times, most recently
from
bdceb76
to
be37f77
Compare
MINIFICPP-32: Add windows event log reader MINIFICPP-596: Build core and libminifi artifacts. Must abstract features that are operating system dependent, such as uuid Make update for appveyor MINIFICPP-595: Add bustache loader to facilitate windows MINIFICPP-595: Add lean and mean to avoid appveyor build failures Adding cmake def to avoid redef errors MINIFICPP-596: Add el support
|
Had some issues on a VM environment with build but seems to be just something on that system's configuration. A clean Windows 10 VM as well as a baremetal Win 10 built and worked without issue. Verified some simple flows and expected operation. Will get these items merged. |
MINIFICPP-32: Add windows event log reader MINIFICPP-596: Build core and libminifi artifacts. Must abstract features that are operating system dependent, such as uuid Make update for appveyor MINIFICPP-595: Add bustache loader to facilitate windows MINIFICPP-595: Add lean and mean to avoid appveyor build failures Adding cmake def to avoid redef errors MINIFICPP-596: Add el support MINIFICPP-596: Change supportsExpressionLangauge to expressionLanguageScope This closes apache#394. Signed-off-by: Aldrin Piri <aldrin@apache.org>
MINIFICPP-32: Add windows event log reader
MINIFICPP-596: Build core and libminifi artifacts. Must abstract
features that are operating system dependent, such as uuid
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.