This repository has been archived by the owner on May 14, 2021. It is now read-only.
MINIFI-452 Updating MiNiFi to 1.6.0 NiFi components. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzonthemtn
reviewed
May 2, 2018
| try { | ||
| return Files.getFileStore(container.toPath()).name(); | ||
| } catch (IOException e) { | ||
| return null; |
There was a problem hiding this comment.
Wondering if there's any use in logging the error?
There was a problem hiding this comment.
Combing through source, I don't think there is a lot to glean from this scenario. If I am overlooking something let me know and we should be sure to make the appropriate changes in NiFi, where this is grabbed from; one of the unfortunate idiosyncrasies of the current model that minifi is.
There was a problem hiding this comment.
I don't disagree -- you would know better than me anyway. :)
jzonthemtn
approved these changes
May 2, 2018
This closes apache#123. Signed-off-by: Aldrin Piri <aldrin@apache.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.