NIFIREG-234: Publish events for tenant CRUD

[brosander]

No description provided.

[kevdoran]

Thanks for the contribution, @brosander. Will review...

[brosander]

Thanks @kevdoran it seems like there are sporadic failures around some of the tests, that's why all the close/reopen, my other pr had seemingly unrelated test failures as well...

[brosander]

Ex:

https://travis-ci.org/apache/nifi-registry/jobs/504770097

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

During install of the assembly

[kevdoran]

I had a chance to pull this down and test it today. It is a nice addition of Event instrumentation for tenants. I had a couple minor comments that I am interested in other people's opinion on.

[kevdoran]

Tenant Events should probably have the identifier field as well.

[brosander]

Good point, will add

[kevdoran]

I'n not sure we should reuse the EventFieldName.USER for the the user that was created. In other contexts it indicates the user that performed the operation (speaking of which, maybe we want that information for tenant CRUD events?)

I would suggest adding new EventFieldNames that align with the the tenant data model, such as TENANT_ID and TENANT_IDENTITY that can be used for all tenant types, or if we want to break it down into users and groups, USER_ID, USER_IDENTITY, USER_GROUP_ID, USER_GROUP_IDENTITY. What do you think?

[brosander]

I think USER_ID, USER_IDENTITY, USER_GROUP_ID, USER_GROUP_IDENTITY more closely matches the terminology in object, methods of the tenant resource but don't have very strong feelings either way.

[brosander]

@kevdoran I think I've addressed the feedback, please let me know if I've missed anything or if further changes are needed

[kevdoran]

Thanks for making those changes, @brosander. +1, merging to master