NIFI-3362 update FlowConfiguration.xsd to allow all current time period units #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mosermw No problem and seems okay. Was able to verify anticipated behavior for this and will get merged. |
asfgit
pushed a commit
that referenced
this pull request
Feb 17, 2017
…od units This closes #1509. Signed-off-by: Aldrin Piri <aldrin@apache.org>
|
@mosermw I guess since this isn't going into master, the magical "closes" statement won't register. Could you please close this when you have the opportunity? Thanks! |
|
Thank you @apiri ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apiri I pulled out the new unit test that was in master from this 0.x PR. I would have needed a new flow.xml for the unit test to validate. I didn't feel it was critical to include the test in 0.x considering that we have it in master, moving forward. Please let me know if you disagree, and I will amend this PR. Thanks!