Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-3803 - Allow use of up/down arrow keys... #2170

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@yuri1969
Copy link
Contributor

commented Sep 22, 2017

...during selection in Add Processor dialog

  • Added navigation logic to both Add Processor and Add CS dialogs.
  • No extending to the SlickGrid library done.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

NIFI-3803 - Allow use of up/down arrow keys...
...during selection in Add Processor dialog

* Added navigation logic to both Add Processor and Add CS dialogs.
* No extending to the SlickGrid library done.
@mcgilman

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2017

Will review...

@mcgilman

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2017

Thanks for the PR @yuri1969! I had tried implementing this awhile back allowing the user to tab into the table and then navigate from there. I wasn't thrilled with the solution as it required the user to tab twice to get focus into the first visible row. I believe the double tab was required due to the 'focusSink' that SlickGrid adds to the DOM [1]. This functionality is already in master. In conjunction with your PR, I like the capability much better. Now the user can navigate from the filter field and from the table if they get focus into the table via tab (albeit double tab) or clicking on a row.

Just a couple minor comments on the PR.

  • I believe these nfFilteredDialogCommon needs to be included in nf-settings for the Add Reporting Task dialog.
  • Also, I was wondering if it would be possible for pageDown/pageUp to select the first/last visible row after navigating. The behavior seems a little inconsistent currently. If the table has/had focus from clicking on a row, then the pageDown/pageUp behavior seems right. If it hasn't, the pageDown/pageUp just navigates the view but does not change the selected row. It would be nice if the selected row changed with the view regardless if the navigation is being triggered through nfFilteredDialogCommon or through the existing capabilities. Let me know if you need to me to explain what I'm seeing further.

[1] https://github.com/mleibman/SlickGrid/blob/bf4705a96c40fea088216034def4d0256a335e65/slick.grid.js#L237

NIFI-3803 - Allow use of up/down arrow keys...
...during selection in Add Processor dialog

* Ported the new functionality to the Add Reporting Task dialog.
* Mimicked SlickGrid's PageUp/Down behavior.
@yuri1969

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2017

@mcgilman

  • Thanks for pointing out this one. I forgot to include the Add Reporting Task dialog completely...
  • Now the nfFilteredDialogCommon should follow the SlickGrid's PageUp/Down navigation style. Please, check whether there are any differences.

@asfgit asfgit closed this in c29ee4a Oct 5, 2017

@mcgilman

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2017

Thanks @yuri1969! This has been merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.