Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5066: Allow global enable/disable component requests #2633

Closed
wants to merge 1 commit into from

Conversation

mcgilman
Copy link
Contributor

NIFI-5066:

  • Allowing the enable/disable buttons to be active under the same conditions as the start/stop buttons.

- Allowing the enable/disable buttons to be active under the same conditions as the start/stop buttons.
@andrewmlim
Copy link
Contributor

Changes look good. Enable/disable and start/stop buttons behave consistently. This is minor, but it would be nice if all of these buttons were greyed out (or unavailable in the context menu) when there were no components available i.e. when the process group is empty.

@scottyaslan
Copy link
Contributor

+1 for the UI code.

@mcgilman
Copy link
Contributor Author

@andrewmlim When no components are selected both enable/disable and start/stop should be allowed as the request will be applied to all eligible components in the current process group.

@asfgit asfgit closed this in 6938e58 Apr 25, 2018
@markap14
Copy link
Contributor

@mcgilman many thanks for adding this improvement. Code looks good. Was able to verify functionality and everything worked exactly as I expected. +1 merged to master.

@mcgilman mcgilman deleted the NIFI-5066 branch May 24, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants