Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5362: When a processor is terminated and has no more active thre… #2832

Closed
wants to merge 1 commit into from

Conversation

markap14
Copy link
Contributor

@markap14 markap14 commented Jul 2, 2018

…ads, ensure that we set this.hasActiveThreads = false

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…ads, ensure that we set this.hasActiveThreads = false
@pvillard31
Copy link
Contributor

reviewing...

@pvillard31
Copy link
Contributor

+1, ran a build with the fix and confirmed expected behavior, merging to master, thanks @markap14

@asfgit asfgit closed this in b549fbb Jul 2, 2018
asfgit pushed a commit that referenced this pull request Jul 12, 2018
…ads, ensure that we set this.hasActiveThreads = false

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #2832.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants