-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-5701 Add documentation for Load Balancing connections to User Gu… #3080
Conversation
…ide and add additional properties to Admin Guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing...
@@ -986,13 +991,11 @@ automatically be 'cloned', and a copy will be sent to each of those Connections. | |||
|
|||
==== Settings | |||
|
|||
The Settings Tab provides the ability to configure the Connection's name, FlowFile expiration, Back Pressure thresholds, and | |||
Prioritization: | |||
The Settings Tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Settings Tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization: | |
The Settings tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other instances in the doc where tab is capitalized similarly:
-Line 641 "Scheduling Tab"
-Line 680 "Properties Tab"
-Line 681 "Properties Tab"
-Line 981 "Details Tab"
But other instances where it is not capitalized:
-Lines 716 & 717 "Comments tab"
I'm OK with either style, but we should be consistent. So if you like the non-capitalized versions, we need to edit the 4 other instances I noted above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer tab being lowercased, since it's not part of the title of the actual tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
Updated instances where tab did not need to be capitalized. Also added "on" in like 657 to read "The Execution setting is used to determine on which node(s)..."
…ide and add additional properties to Admin Guide
Also updated some existing screenshots and did some reformatting of some titles.