Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5701 Add documentation for Load Balancing connections to User Gu… #3080

Closed
wants to merge 3 commits into from

Conversation

andrewmlim
Copy link
Contributor

…ide and add additional properties to Admin Guide

Also updated some existing screenshots and did some reformatting of some titles.

…ide and add additional properties to Admin Guide
Copy link
Contributor

@jtstorck jtstorck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing...

nifi-docs/src/main/asciidoc/user-guide.adoc Outdated Show resolved Hide resolved
@@ -986,13 +991,11 @@ automatically be 'cloned', and a copy will be sent to each of those Connections.

==== Settings

The Settings Tab provides the ability to configure the Connection's name, FlowFile expiration, Back Pressure thresholds, and
Prioritization:
The Settings Tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Settings Tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization:
The Settings tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other instances in the doc where tab is capitalized similarly:

-Line 641 "Scheduling Tab"
-Line 680 "Properties Tab"
-Line 681 "Properties Tab"
-Line 981 "Details Tab"

But other instances where it is not capitalized:

-Lines 716 & 717 "Comments tab"

I'm OK with either style, but we should be consistent. So if you like the non-capitalized versions, we need to edit the 4 other instances I noted above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer tab being lowercased, since it's not part of the title of the actual tab.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

jtstorck and others added 2 commits October 16, 2018 15:54
Updated instances where tab did not need to be capitalized.  Also added "on" in like 657 to read "The Execution setting is used to determine on which node(s)..."
@asfgit asfgit closed this in 4039c21 Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants