NIFI-5859 Modifications to extension manifest generation to better su…

[bbende]

…pport unmarshalling XML into pojos

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically master)?

• Is your initial contribution a single, squashed commit?

For code changes:

• Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
• Have you written or updated unit tests to verify your changes?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
• If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
• If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[kevdoran]

Reviewing...

[kevdoran]

+1, looks good, @bbende. thanks for keeping this moving forward. will merge to master

[alecosborne]

Hello,

why is the abstractDocumentationWriter.java class from February 26 from the master branch not identical to the version from the 1.9.2 release from April 8?

I think version 1.9.2 was based on branch 6169 and that's why I can not find it in the latest version.

The class from the master branch is needed if I want to create a custom processor and rely on creating the extension-manifest.xml to use the new functions from the nifi registry 0.4.0.

When can we expect a new Nifi version?

Thanks a lot.

AO

[bbende]

@alecosborne Sorry for the issue...

We have a bit of a weird dependency situation where the NAR Maven plugin can't have a direct dependency on nifi-api, it can only assume that nifi-api is on the classpath of the NAR being built, but then the code for generating the manifest needs to be based on the API so it has to live in the API.

So we released a version of the manifest docs stuff in nifi-api 1.9.2, but then while continuing to work on registry 0.4.0 there were more changes needed, so we haven't yet released nifi-api 1.10.0 which would have the necessary changes.

What you would have to do for now is build nifi-api from master using a 'mvn clean install', then change the dependencies in your custom NAR to use nifi-api 1.10.0-SNAPSHOT. Part of it will depend on whether your custom NAR has a parent of nifi-nar-bundles, if so then you might need your own dependencyManagement to force the version to 1.10.0-SNAPSHOT, if not then you can probably just add the version to the dependency.

https://cwiki.apache.org/confluence/display/NIFI/Maven+Projects+for+Extensions#MavenProjectsforExtensions-Inheritance

We should document this somewhere though so that it is clear that the extension capabilities in registry are meant to be used with the next released version NiFi and nifi-api. I will try to think of where this makes sense to be documented.