Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6905 Prevent non-primary nodes to connect Twitter API when runni… #3909

Closed
wants to merge 2 commits into from

Conversation

k0urge
Copy link
Contributor

@k0urge k0urge commented Nov 29, 2019

…ng in primary node only mode.

Description of PR

GetTwitter processor, configured to run on primary node only, initializes connection to Twitter API from every NiFi cluster node, even on non-primary nodes.
Prevent non-primary nodes to connect Twitter API when running in primary node only mode. This Fixes bug NIFI-6905:

I updated the GetTwitter processor onScheduled() method to only create a clientBuilder without connecting it to the Twitter API.
Connection is now initialized by the onTrigger() method when it needs it (in primary node only mode onTrigger() never run on non primary nodes....).
Added onPrimaryNodeChange() to close connection on PRIMARY_NODE_REVOKED events.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@asfgit asfgit closed this in 43bc6c6 Dec 13, 2019
@markap14
Copy link
Contributor

Thanks @kourge-ch ! Was able to verify that everything is working as expected and code review looks good. Thanks for fixing that! +1 merged to master.

tpalfy pushed a commit to tpalfy/nifi that referenced this pull request Dec 16, 2019
…n in primary node only mode.

This closes apache#3909.

Signed-off-by: Mark Payne <markap14@hotmail.com>
patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
…n in primary node only mode.

This closes apache#3909.

Signed-off-by: Mark Payne <markap14@hotmail.com>
natural pushed a commit to natural/nifi that referenced this pull request Feb 1, 2020
…n in primary node only mode.

This closes apache#3909.

Signed-off-by: Mark Payne <markap14@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants