Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6955 close streams in Reader/writer mock #3946

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

IlyaKovalev
Copy link
Contributor

@IlyaKovalev IlyaKovalev commented Dec 19, 2019

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

ArrayListRecordReader (nifi-mock-record-utils) obtain inputStream in own constructor but don't close this.
ArrayListRecordWriter has the same problem with outputStream.
So if in custom processor i use
InputStream in = session.read(flowfile)
reader = factory.createRecordReader(flowfile, in, logger)
reader.close()
Tests fail and complain that file didn't close.

Add streams and close them in close()

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@markap14 markap14 merged commit 209c560 into apache:master Jan 7, 2020
@markap14
Copy link
Contributor

markap14 commented Jan 7, 2020

Thanks @IlyaKovalev! I have merged your changes to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants