NIFI-8354 ExecuteStreamCommand processor doesn't delete the temp file… #4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the process start failed
| @@ -471,6 +471,7 @@ public void onTrigger(ProcessContext context, final ProcessSession session) thro | |||
| try { | |||
| process = builder.start(); | |||
| } catch (IOException e) { | |||
There was a problem hiding this comment.
delete() can throw several exceptions here, I think they should be handled.
maybe
There was a problem hiding this comment.
Thanks for your review, I have added the exception handling
I didn't use the FileUtils you mentioned
As far as I know, components need to use ComponentLog to record logs to distinguish the components in the same instance.
But FileUtils does not support it. so I handle the exception directly.
ottobackwards
approved these changes
Mar 24, 2021
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
apache#4923) * NIFI-8354 ExecuteStreamCommand processor doesn't delete the temp file if the process start failed * NIFI-8354 Record the log when delete file failed This closes apache#4923 Signed-off-by: Otto Fowler <otto@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… if the process start failed
Description of PR
Delete the temp file to avoid the i-node of /tmp full
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.