Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-8354 ExecuteStreamCommand processor doesn't delete the temp file… #4923

Merged
merged 2 commits into from Mar 24, 2021
Merged

NIFI-8354 ExecuteStreamCommand processor doesn't delete the temp file… #4923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ae9b2c
NIFI-8354 ExecuteStreamCommand processor doesn't delete the temp file…
s9514171 Mar 23, 2021
268bcb3
NIFI-8354 Record the log when delete file failed
s9514171 Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...rd-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java
View file
Open in desktop
Expand Up @@ -471,6 +471,13 @@ public void onTrigger(ProcessContext context, final ProcessSession session) thro
try {
process = builder.start();
} catch (IOException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete() can throw several exceptions here, I think they should be handled.
maybe

nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/util/FileUtils.java

Line 77 in f9ae3bb

public static boolean deleteFile(final File file, final Logger logger) {
, and the component logger passed so failures can be logged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, I have added the exception handling

I didn't use the FileUtils you mentioned
As far as I know, components need to use ComponentLog to record logs to distinguish the components in the same instance.
But FileUtils does not support it. so I handle the exception directly.

try {
if (!errorOut.delete()) {
logger.warn("Unable to delete file: " + errorOut.getAbsolutePath());
}
} catch (SecurityException se) {
logger.warn("Unable to delete file: '" + errorOut.getAbsolutePath() + "' due to " + se);
}
logger.error("Could not create external process to run command", e);
throw new ProcessException(e);
}
Expand Down