NIFI-11553 - additional configurability for GCP processors; PublishGC… #7274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exceptionfactory
requested changes
May 25, 2023
There was a problem hiding this comment.
Thanks for working on these improvements @greyp9. I noted several suggestions related to removing the stored exception handling and redesigning failed message handling. It would also be helpful to improve retry handling such that other exceptions like UnavailableException also result in sending to the retry relationship.
...essors/src/test/java/org/apache/nifi/processors/gcp/pubsub/lite/PublishGCPubSubLiteTest.java
Outdated
Show resolved
Hide resolved
...-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSubTest.java
Outdated
Show resolved
Hide resolved
...essors/src/main/java/org/apache/nifi/processors/gcp/pubsub/publish/ContentInputStrategy.java
Outdated
Show resolved
Hide resolved
...rocessors/src/main/java/org/apache/nifi/processors/gcp/pubsub/AbstractGCPubSubProcessor.java
Show resolved
Hide resolved
...rocessors/src/main/java/org/apache/nifi/processors/gcp/pubsub/AbstractGCPubSubProcessor.java
Show resolved
Hide resolved
...nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
Outdated
Show resolved
Hide resolved
...nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
Outdated
Show resolved
Hide resolved
...nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
Outdated
Show resolved
Hide resolved
...nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
Outdated
Show resolved
Hide resolved
...nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
Outdated
Show resolved
Hide resolved
exceptionfactory
requested changes
Jun 6, 2023
There was a problem hiding this comment.
Thanks for making the updates @greyp9, the latest version looks good in terms of the general options for message creation, either FlowFile oriented or Record oriented. I noted some minor recommendations on naming and test implementation.
...ssors/src/main/java/org/apache/nifi/processors/gcp/pubsub/publish/NiFiApiFutureCallback.java
Outdated
Show resolved
Hide resolved
...-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSubTest.java
Outdated
Show resolved
Hide resolved
...-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSubTest.java
Outdated
Show resolved
Hide resolved
...-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSubTest.java
Show resolved
Hide resolved
...-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSubTest.java
Outdated
Show resolved
Hide resolved
...p-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/publish/FlowFileResult.java
Outdated
Show resolved
Hide resolved
...p-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/publish/FlowFileResult.java
Outdated
Show resolved
Hide resolved
...nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
Outdated
Show resolved
Hide resolved
...nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
Outdated
Show resolved
Hide resolved
...nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
Outdated
Show resolved
Hide resolved
…PubSub supports record-oriented FlowFile processing
exceptionfactory
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Thanks for working through the feedback @greyp9! The latest version looks good and works as expected with both FlowFile and Record oriented publishing strategies. +1 merging
exceptionfactory
pushed a commit
that referenced
this pull request
Jun 13, 2023
- Added Message Derivation Strategy to PublishGCPubSub with FlowFile and Record options - Added API Endpoint property to PublishGCPPubSub and ConsumeGCPubSub - Added Batch configuration properties This closes #7274 Signed-off-by: David Handermann <exceptionfactory@apache.org> (cherry picked from commit 336b857)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…PubSub supports record-oriented FlowFile processing
Summary
NIFI-11553
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation