-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-12231 FetchSmb supports Move and Delete Completion Strategies #8617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integration tests workflow failed on FetchSmbIT
for the following tests:
FetchSmbIT.testCompletionStrategyDelete:114 expected: <false> but was: <true>
FetchSmbIT.testCompletionStrategyMoveWithCreatingDirectory:149 expected: <false> but was: <true>
Thanks for the heads-up @exceptionfactory! |
Used different directory names for the test cases Used variables for directory and file names Add extra assertions for checking no warnings happen
@exceptionfactory I managed to fix the tests by changing the logic in FetchSmb. There were 2 overlapping sessions to the SMB server: one for reading the file and the other for executing the completion strategy (move or delete) in Parallel sessions should not cause issues as the file handles are closed properly and it worked in my environments (ran flows connecting to Windows share and Samba share, ran integrations tests on Mac and Linux). Not sure what the docker environment is doing in Github CI but this change fixed it. I re-ran the integration tests 3 times and all were green. |
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes #8617.
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#8617.
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#8617.
Summary
NIFI-12231
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation