NIFI-2608 reworked consumer to match API. Added support for 0.10 client in addition. More notes on JIRA #930
Conversation
|
I've been reviewing this... so far I have tested ConsumeKafka and PublishKafka (0.9.0) against an Apache Kafka 0.9.0 broker, with PLAINTEXT and also with SSL, and both appear to be working well. Trying to setup a Kerberos scenario to test SASL. |
|
Quick update... I was finally able to get a Kerberos environment setup and did a successful test with SASL, so that covers the 0.9.0 client against the 0.9.0 broker, with PLAINTEXT, SSL, and SASL. I'm planning to do the same tests with the 0.10 client and 0.10 broker tomorrow. |
|
Update on weird behavior with subclassing. Turns out I can run either 0.9 or 0.10. Whichever runs first wins. There is clearly something going on with classloading. Looking into Kafka source code and what we're doing as well. |
|
Problem identified. Filed as NIFI-2660 |
Signed-off-by: joewitt <joewitt@apache.org>
| */ | ||
| public static NarCloseable withComponentNarLoader(final Class componentClass) { | ||
| final ClassLoader current = Thread.currentThread().getContextClassLoader(); | ||
| Thread.currentThread().setContextClassLoader(NarThreadContextClassLoader.getInstance()); |
There was a problem hiding this comment.
I think this line is superfluous - we are immediately overwriting the context class loader in the next line.
|
Using the latest updates I was able to verify the 0.10 processors against the 0.10 broker using PLAINTEXT, SSL, and SASL, and also tested the 0.9.0 processors against an 0.10 broker. I'm a +1 to merge this in. |
|
@joewitt I've not reviewed the entire PR here, but did review the commit for the changes to class loading, and I believe these changes to be correct. I made one in-line comment but other than that I am a +1 to merge to master. Nice catch there. I think it definitely is a cleaner and more correct approach. |
…mer API. Made nar classloading more precise to support spawned threads NIFI-2660.
No description provided.