NIFI-2665: Fixed intermittent validation errors in InvokeScriptedProcessor#942
Closed
mattyb149 wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-2665: Fixed intermittent validation errors in InvokeScriptedProcessor#942mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
code looks good - local testing and will advise. |
Contributor
|
line 70 on invoke scripted should be final. Line 72 should be volatile. otherwise looking good. +1 |
Contributor
|
please do squash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, due to #930 the parent classloaders have been fixed so there is no need for the createScriptEngineModuleClassLoader() method, I removed it as part of the cleanup with script engine creation.
Note the engineQ logic looks extraneous here, but it's in place to keep it common between the scripting processors (ExecuteScript needs one per task, InvokeScriptedProcessor only needs one)