NUTCH-2376 Improve configurability of HTTP Accept* header fields #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Accept, Accept-Language and Accept-Charset are configured and used the same way for both protocol-http and protocol-httpclient - a space as value will unset these header fields (not sent in request)
|
Duplicate PR @sebastian-nagel, please reopen if this is the case |
|
This one is for 1.x/master, #187 is for 2.x. Sorry, the next time I'll also add a statement to which branch the PR applies. Thanks for the review! |
|
Sorry Seb
On Fri, May 19, 2017 at 3:50 AM Sebastian Nagel ***@***.***> wrote:
Merged #186 <#186>.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#186 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ABHJl2SzSHaXXS286NsY2BjLEB36dulnks5r7XP6gaJpZM4NC-yU>
.
--
*Lewis*
Dr. Lewis J. McGibbney Ph.D, B.Sc
Director, MCMA Associates
Phone: +1(626)498-3090
Skype: lewis.john.mcgibbney
Email: lewis.mcgibbney@gmail.com
|
|
No problem, it's easily overseen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same way for both protocol-http and protocol-httpclient
I've tried to overwrite the default by an empty value but that's not possible with the Hadoop configuration mechanism. Of course, one could configure instead
*as "Accept-Language" or "Accept-Charset" (resp.*/*as "Accept" content type) but that will unnecessarily blow up the HTTP requests.