testing/ostest: add test case for task priority change with locked scheduler

[pkarashchenko]

Summary

This test helps to verify that scheduler lock/unlock functionality is working as expected.
Currently there is a bug, so test fails.

Impact

More test coverage

Testing

The test pass if apache/nuttx#7464 is applied

[davids5]

@pkarashchenko this looks fine. But I have a general comment about the os tests: I would like to see an short explanation of what the test method is and what is expected. Some times I find this lost in clever code.

[pkarashchenko]

Ok. Could you please point me to some examples, or should I just place some explanations in the comments?

[pkarashchenko]

Currently this is blocked by #1716

[xiaoxiang781216]

@pkarashchenko please rebase your patch

[hartmannathan]

Continuing what @davids5 was saying, I think a comment in the code that explains the purpose of the test and what we expect from it will help people reading the code later.

Separately, another idea:

Since the test is expected to fail due to a bug, I think we should modify the ostest program to tally five possible results from each test, like some other test suites do: pass, fail, expected fail, unexpected pass, skipped.

Explanation:

• pass: the test passed as expected

• fail: the test should have passed but it failed

• expected fail: the test failed and it was expected to fail because of a known bug; that is the situation with the test in this PR. We should tally such failures separately from above-mentioned fail because they are caused by known bugs

• unexpected pass: we expected the test to fail with "expected fail" because of a known bug, but to our surprise, it passed unexpectedly

• skipped: the test is not being run because the hardware or build doesn't support it; e.g., the priority inheritance tests will be skipped in a non-priority-inheritance build

[jerpelea]

@pkarashchenko please add commit message describing the change

[pkarashchenko]

@pkarashchenko please add commit message describing the change

Should I modify all the three commits? I'm not sure that commit that adds missing comment needs any other description than testing/ostest: add missing section comments currently available.

[davids5]

@pkarashchenko Thank you

[pkarashchenko]

Seems like apache/nuttx#9981 is needed to move forward

[pkarashchenko]

@xiaoxiang781216 do you have any ideas why sim:citest fails? Initially I thought that it is a timeout issue, but seems like it is not, I can run the tests locally and all test pass

=========================================================== test session starts ===========================================================
platform linux -- Python 3.8.10, pytest-6.2.5, py-1.11.0, pluggy-1.2.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /home/homedir/nuttx/tools/ci/testrun, configfile: pytest.ini
plugins: repeat-0.9.1, ordering-0.6, json-0.4.0
collected 12 items                                                                                                                        

test_example/test_example.py::test_hello PASSED                                                                                     [  8%]
test_example/test_example.py::test_helloxx PASSED                                                                                   [ 16%]
test_example/test_example.py::test_pipe PASSED                                                                                      [ 25%]
test_example/test_example.py::test_popen PASSED                                                                                     [ 33%]
test_example/test_example.py::test_usrsocktest PASSED                                                                               [ 41%]
test_os/test_os.py::test_ostest PASSED                                                                                              [ 50%]
test_os/test_os.py::test_mm PASSED                                                                                                  [ 58%]
test_os/test_os.py::test_cxxtest PASSED                                                                                             [ 66%]
test_os/test_os.py::test_scanftest PASSED                                                                                           [ 75%]
test_os/test_os.py::test_getprime PASSED                                                                                            [ 83%]
test_os/test_os.py::test_fs_test PASSED                                                                                             [ 91%]
test_os/test_os.py::test_psram_test PASSED                                                                                          [100%]

But on CI the test_os/test_os.py::test_ostest fails.

[xiaoxiang781216]

@ttnie could you check why the citest fail?

[pkarashchenko]

@xiaoxiang781216 seems this should fix the root cause apache/nuttx#10016
But still I do not understand why it works locally for me.

[xiaoxiang781216]

@xiaoxiang781216 seems this should fix the root cause apache/nuttx#10016 But still I do not understand why it works locally for me.

without SIM_WALLTIME_SIGNAL, simulator timing doesn't sync with the PC wall clock. I guess the ci server either run to fast or slow than your PC.