Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imxrt: flexcan use hpwork for receiving frames #10087

Merged
merged 1 commit into from Aug 4, 2023

Conversation

PetervdPerk-NXP
Copy link
Contributor

Summary

FlexCAN before used interrupts to process incoming frames.
This patch adds a HPWORK workqueue to process incoming frames in the workqueue context instead.

Also renamed mbi to txmb for better readability.

Testing

FMURT7
MIMXRT1064-EVK build

@PetervdPerk-NXP PetervdPerk-NXP force-pushed the pr-flexcan-hpwork branch 2 times, most recently from e9779ed to 02649a9 Compare August 4, 2023 13:40
Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raiden00pl
Copy link
Contributor

I think #5142 is related and this PR fixes issue for imxrt (the rest of the chips with flexcan are still affected)

@PetervdPerk-NXP
Copy link
Contributor Author

Indeed it fixes #5142 for imxrt which has been extensively tested with high bus load.
It could also fix for S32K1XX and S32K3XX but both chips have less RX mailboxes.
So highload testing has to be done again for these other chips.

@acassis
Copy link
Contributor

acassis commented Aug 4, 2023

@PetervdPerk-NXP please include the Summary message in the commit message. It is important as future reference

FlexCAN before used interrupts to process incoming frames.
This patch adds a HPWORK workqueue to process incoming frames in the workqueue
context instead. Also renamed mbi to txmb for better readability.
@pkarashchenko pkarashchenko merged commit 0b721ac into apache:master Aug 4, 2023
26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.3.0 Sep 26, 2023
@jerpelea jerpelea moved this from To-Add to done in Release Notes - 12.3.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

FlexCAN can_input() should not be called directly from interrupt handler
7 participants