Fix: s32k1 s32k3 kinetis: add propseg to ctrl1 timing mask #10232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
approved these changes
Aug 15, 2023
acassis
approved these changes
Aug 15, 2023
|
Hi @macdonaldryan please rebase and squash these commits. |
macdonaldryan
force-pushed
the
s32k1_s32k3_kinetis_flexcan-add-propseg-to-ctrl1-timing-mask
branch
from
4d9ee6c
to
aa52ac6
Compare
macdonaldryan
force-pushed
the
s32k1_s32k3_kinetis_flexcan-add-propseg-to-ctrl1-timing-mask
branch
from
aa52ac6
to
f1d6cf4
Compare
|
@acassis thanks for the pointer. I have squashed & rebased. |
|
@PetervdPerk-NXP - Please have a look |
|
@xiaoxiang781216 please take a look at error #14: https://acassis.wordpress.com/2023/06/20/nuttx-ci-github-failures-list/ CI failed to downloaded littlefs for sim test. Is that possible to detect the download fail and retry more 2 times before assuming it is an error? |
Thank you for these fixes! |
|
Ah I see this only happened when |
PetervdPerk-NXP
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The timing mask for the can's ctrl1 register excludes the propagation segment bits. This results in incorrect timing when configuring bitrate at runtime with SIOCSCANBITRATE when the bitrate to timeseg algorithm selects a different propseg value.
Impact
Incorrect can timing configuration when moving between rates at runtime.
Testing
s32k1xx HW testing: moving between several speeds both in listen only and while actively participating on the network.