arch/intel64: various cosmetic improvements after code review #11758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use tab at the beginning of lines, remove C++ comments, fix some tabs to spaces Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
acassis
reviewed
Feb 23, 2024
…nctions there to follow the approach in other architectures Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
BSS nulling can now be optimized by the compiler, so it is necessary to enable SSE instructions early in __nxstart Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
to follow NuttX coding standard Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
szafonimateusz-mi
force-pushed
the
patchset3
branch
from
40bd6d2
to
904c23a
Compare
xiaoxiang781216
approved these changes
Feb 23, 2024
jerpelea
approved these changes
Feb 23, 2024
pkarashchenko
approved these changes
Feb 23, 2024
|
I noticed that qemu-intel64:nsh can not boot with this PR on ubuntu 20.04 x86_64 (Core-i7 11700) + QEMU-8.2.0. |
|
@masayuki2009 I'll fix it right away. |
|
@masayuki2009 fixed here #11764 I messed up something in my patches |
Please make sure that your commits work with the latest upstream whenever you modify your commits. |
szafonimateusz-mi
added a commit
to szafonimateusz-mi/nuttx
that referenced
this pull request
Feb 24, 2024
__revoke_low_memory() is called in intel64_lowsetup() fixes b4b96a6 (PR apache#11758) in which the multiboot2 header was accessed after revoking the low memory which caused page fault. Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
halyssonJr
pushed a commit
to halyssonJr/nuttx
that referenced
this pull request
Apr 10, 2024
__revoke_low_memory() is called in intel64_lowsetup() fixes b4b96a6 (PR apache#11758) in which the multiboot2 header was accessed after revoking the low memory which caused page fault. Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
use tab at the beginning of lines, remove C++ comments, fix some tabs to spaces
to follow the approach in other architectures
BSS nulling can now be optimized by the compiler, so it is necessary
to enable SSE instructions early in __nxstart
to follow NuttX coding standard
Impact
no functional changes, improve code quality
Testing
qemu and intel hw