net/nat: Minor code optimizations #12130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found `struct ipv*_nat_entry` is missing `_s` suffix, but the name is too long in some cases, so maybe `ipv*_nat_entry_t` could be better. Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
xiaoxiang781216
approved these changes
Apr 12, 2024
jerpelea
approved these changes
Apr 12, 2024
Finish apache#12116 (comment) Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
|
Pushing to retrigger the CI which seems failing in an unrelated position. |
anchao
approved these changes
Apr 12, 2024
xiaoxiang781216
approved these changes
Apr 12, 2024
jerpelea
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Patches included:
struct ipv*_nat_entrytoipv*_nat_entry_tstruct ipv*_nat_entryis missing_ssuffix, but the name is too long in some cases, so maybeipv*_nat_entry_tcould be better.Impact
Minor
Testing
CI