Fixed AVR build issues #1410
Merged
Fixed AVR build issues #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iocapa it's better to squash two patch into one. |
iocapa
force-pushed
the
bugfix/avr_build_issues
branch
from
01f512e
to
71140ae
Compare
Done. |
|
I will apply, because is passed on all tests, except macOS tests that probably weren't prepared to compile AVR code. |
|
@iocapa We now have AVR support in the CI system, thanks for pushing us in that direction. I had to make a few other changes to handle some warnings. Hopefully this will help keep the port in better shape. Please open bugs/pr on anything else you run into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Build failed for the aforementioned platform
Testing