libxx: Integrate uClibc++ latest official release #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ouss4
reviewed
Jul 16, 2020
| @@ -313,6 +313,7 @@ ifneq ($(CONFIG_ARCH_CHIP),) | |||
| endif | |||
|
|
|||
| dirlinks: include/arch include/arch/board include/arch/chip $(ARCH_SRC)/board $(ARCH_SRC)/chip drivers/platform | |||
| $(Q) $(MAKE) -C libs/libxx dirlinks TOPDIR="$(TOPDIR)" | |||
There was a problem hiding this comment.
This should go to Makefile.win too.
There was a problem hiding this comment.
Good catch, I will provide a patch fix it.
There was a problem hiding this comment.
@Ouss4 done.
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I05377a0a7674f1cbe461ce67960bd3dc62729337
xiaoxiang781216
force-pushed
the
uClibc++
branch
from
bf3a1c8
to
1082e46
Compare
Ouss4
reviewed
Jul 17, 2020
| @@ -95,7 +97,7 @@ clean: | |||
| $(call DELFILE, $(BIN)) | |||
| $(call CLEAN) | |||
|
|
|||
| distclean: clean | |||
| distclean:: clean | |||
There was a problem hiding this comment.
@xiaoxiang781216 users of other C++ libraries will need to be aware if this change, right? Their distclean would fail otherwise.
There was a problem hiding this comment.
I will provide the new patch for libcxx too. Like uClibc++, we don't need maintain the private copy anymore, the official release can be directly used.
BTW, I can't fix libcxx/Make.defs since it is in Alan's git:
https://bitbucket.org/acassis/libcxx/src/master/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the recent enhancement, we can directly use the offiical uClibc++ package, so let's download the package from the official website.
Impact
User don't need manually setup uClibc++ environment, the build system will do it automatically.
Testing