can: fix RTR ioctl and support timeout #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTres19
force-pushed
the
MTres19/fix-can-rtr-ioctl
branch
from
04a8da6
to
673222e
Compare
MTres19
force-pushed
the
MTres19/fix-can-rtr-ioctl
branch
from
673222e
to
a8fa6fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The RTR ioctl was not really usable (and few (any?) drivers implemented it. However, it's potentially useful and doesn't require a lot of work to support.
Impact
No changes needed to existing drivers. If drivers would like to support this ioctl, they should support/enable
CONFIG_CAN_USE_RTRand setco_remoterequestto NULL.Testing
Tested with TM4C123G Launchpad. Test application.