esp32/esp32_spiflash.c: Fix the value of the page start address when invalidating the cache #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
address. It was incorrectly taken from the size. Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the value of the page start address when invalidating the cache. The value was incorrectly set to be the
sizeinstead ofstart.Impact
Fix a bug that will make invalidating the cache happen more frequently.
Testing
esp32-devkitc:spiflash
Some NXStyle issues are expected due to the ROM functions usage.