Add CAN FD flags to CAN header #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4r0u53k
changed the title
|
@j4r0u53k please fetch the latest master, rebase your change and push -f again. |
EDL, BRS and ESI bits added to struct can_hdr_s. The `ch_unused' field is useless (adjacent fields in packed structs are aligned to the next byte), but some drivers explicitly set this field to zero, so it is kept there for API backward compatibility. Signed-off-by: Jaroslav Beran <jara.beran@gmail.com>
Because buflen is size_t (unsigned) and nsent is ssize_t (signed) of the same size, (buflen - nsent) results in unsigned and overflows if nsent > buflen. This happens when sending CAN FD frame with DLC > 8 and a user gets the buflen parameter as a result of CAN_MSGLEN(len) where `len' is the size of data which is less then a size for some extended DLC (e.g. 26 bytes is sent in a message with DLC 0xD, which has 32 bytes of data). The correct buflen value should be rather CAN_MSGLEN(can_dlc2bytes(can_bytes2dlc(len))) Signed-off-by: Jaroslav Beran <jara.beran@gmail.com>
j4r0u53k
force-pushed
the
add-can-fd-flags-to-can-header
branch
from
571dd60
to
b875eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The first commit 333345a adds EDL, BRS and ESI bits added to struct can_hdr_s.
The `ch_unused' field is useless (adjacent fields in packed structs are aligned to the next byte), but some
drivers explicitly set this field to zero, so it is kept there for backward compatibility of the API.
When started using DLC > 8 a bug in can_write was revealed. This is fixed (or I would better say work arounded with respect to keeping maximum backward compatibility and not possibly breaking other components) in commit 571dd60.
Impact
These changes are API backward compatible.
Testing
Tested on Bosch M_CAN controller on SAMv7 chip (needs additional changes to that driver not included in this pull request).