include/spawn.h: Add POSIX_SPAWN_SETSID definition #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavonihei
reviewed
May 7, 2021
include/spawn.h
Outdated
| @@ -53,6 +53,7 @@ | |||
| #define POSIX_SPAWN_SETSCHEDULER (1 << 3) /* 1: Set task's scheduler policy */ | |||
| #define POSIX_SPAWN_SETSIGDEF (1 << 4) /* 1: Set default signal actions */ | |||
| #define POSIX_SPAWN_SETSIGMASK (1 << 5) /* 1: Set sigmask */ | |||
| #define POSIX_SPAWN_SETSID (1 << 7) /* 1: Create the new session */ | |||
There was a problem hiding this comment.
Since this flag is not supported by NuttX, I believe that the implementation should at least return the appropriate error code (e.g. ENOSYS) when this flag is used by the API consumer.
There was a problem hiding this comment.
Here is some reason I don't add the code to check the flag:
- NuttX doesn't support the session concept, so we can simply model that all processes share a global session and ignore the request safely.
- In the standard implementation, tty driver work with the scheduler do some special action for the different session, but the difference is very minor and NuttX actually treat that all processes are equal regarding the session. It isn't good to stop the program just because the minor(no for NuttX) difference.
@gustavonihei what do you think?
There was a problem hiding this comment.
Ok, seems reasonable. On 2 I agree that would be a bad idea to stop the program for this reason.
There was a problem hiding this comment.
Should we add a comment indicating that this flag (and possible others to come) are not from POSIX standard, or indicating where is it from?
gustavonihei
approved these changes
May 9, 2021
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: I7ad654a1cb9b74a9f27f52c88fffa8b487a48f33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NuttX doesn't support session yet, but the definition can improve the compatibility.
Impact
Minor, new flag
Testing
Pass the build