Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to ESP32-S2 and ESP32S2-SAOLA-1 Board #3803

Merged
merged 7 commits into from
Jun 1, 2021
Merged

Add support to ESP32-S2 and ESP32S2-SAOLA-1 Board #3803

merged 7 commits into from
Jun 1, 2021

Conversation

acassis
Copy link
Contributor

@acassis acassis commented May 30, 2021 •
edited
Loading

Summary

This PR add support to ESP32-S2 Xtensa LX7

Impact

N/A

Testing

esp32s2-saola-1

NOTE: The CI will fail because Mixed case and operator/assignment must be preceded with whitespace in the tie-asm.h assembly macro

@acassis acassis changed the title Add support to ESP32-S2 Add support to ESP32-S2 and ESP32S2-SAOLA-1 Board May 30, 2021
@jerpelea
Copy link
Contributor

jerpelea commented May 31, 2021 •
edited
Loading

@acassis please fix the nxstyle errors and add commit messages

@jerpelea jerpelea self-requested a review May 31, 2021 06:40
@acassis
Copy link
Contributor Author

acassis commented May 31, 2021

@acassis please fix the nxstyle errors and add commit messages

Hi @jerpelea I commented about the nxstyle errors in the Summary, fixing the assembly macro to pass on nxstyle results in error.

@jerpelea jerpelea merged commit 929a4a7 into apache:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerpelea jerpelea Awaiting requested review from jerpelea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acassis @jerpelea @Ouss4 @saramonteiro