Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local/stream: remove preamble header in stream mode #4197

Merged
merged 2 commits into from Jul 22, 2021

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Jul 21, 2021

Summary

local/stream: remove preamble header in stream mode
net/local: remove unused client lc_remaining

Preamble sync header is no necessary in stream mode

Impact

local socket with AF_UNIX & SOCK_STREAM

Testing

socket & socketpair

Signed-off-by: chao.an <anchao@xiaomi.com>
@anchao anchao requested a review from yamt July 21, 2021 09:13
@davids5 davids5 requested a review from antmerlino July 21, 2021 09:41
@anchao anchao force-pushed the 21072101 branch 3 times, most recently from 643112a to 28e2464 Compare July 21, 2021 15:50
Preable sync header is no necessary in stream mode

Signed-off-by: chao.an <anchao@xiaomi.com>
Copy link
Contributor

@antmerlino antmerlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoxiang781216 xiaoxiang781216 merged commit a48513a into apache:master Jul 22, 2021
@Ouss4 Ouss4 added this to To-Add in Release Notes - 10.2 Oct 11, 2021
@jerpelea jerpelea moved this from To-Add to fixes in Release Notes - 10.2 Oct 13, 2021
@jerpelea jerpelea moved this from fixes to Added in Release Notes - 10.2 Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants