Fix a few deadlock in tcp/iob #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If threads are blocking for throttled allocation, g_throttle_sem.semcount doesn't represent the number of usable IOBs well. Note: For non-throttled allocations, the g_iob_committed mechanism is a rescue. But there is no equivalent for throttled allocations.
Ensure to put the wrb back onto the write_q when blocking on iob allocation. Otherwise, it can deadlock with other threads doing the same thing.
|
i will restart jobs as the failure looks unrelated to this PR. |
xiaoxiang781216
approved these changes
Jul 31, 2021
yamt
added a commit
to yamt/incubator-nuttx
that referenced
this pull request
Aug 6, 2021
Fix a wrong assertion in: ``` commit 98ec46d Author: YAMAMOTO Takashi <yamamoto@midokura.com> Date: Tue Jul 20 09:10:43 2021 +0900 tcp_send_buffered.c: fix iob allocation deadlock Ensure to put the wrb back onto the write_q when blocking on iob allocation. Otherwise, it can deadlock with other threads doing the same thing. ``` I forget to submit this with apache#4257
yamt
added a commit
to yamt/incubator-nuttx
that referenced
this pull request
Aug 6, 2021
Fix a wrong assertion in: ``` commit 98ec46d Author: YAMAMOTO Takashi <yamamoto@midokura.com> Date: Tue Jul 20 09:10:43 2021 +0900 tcp_send_buffered.c: fix iob allocation deadlock Ensure to put the wrb back onto the write_q when blocking on iob allocation. Otherwise, it can deadlock with other threads doing the same thing. ``` I forget to submit this with apache#4257
xiaoxiang781216
pushed a commit
that referenced
this pull request
Aug 6, 2021
Fix a wrong assertion in: ``` commit 98ec46d Author: YAMAMOTO Takashi <yamamoto@midokura.com> Date: Tue Jul 20 09:10:43 2021 +0900 tcp_send_buffered.c: fix iob allocation deadlock Ensure to put the wrb back onto the write_q when blocking on iob allocation. Otherwise, it can deadlock with other threads doing the same thing. ``` I forget to submit this with #4257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a few deadlock in tcp/iob.
see the commit messages for details.
Impact
tcp/iob
Testing
tested with some of the other patches in #4184