Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched/signal: add spinlock to g_sigfreeaction #4803

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

GUIDINGLI
Copy link
Contributor

Summary

sched/signal: add spinlock to g_sigfreeaction

To avoid nxsig_alloc_action() & nxsig_release_action() competition

Impact

sig_action

Testing

@Ouss4
Copy link
Member

Ouss4 commented Nov 9, 2021

@xiaoxiang781216 @GUIDINGLI How about using a private lock here instead of the global one? cc @masayuki2009

@masayuki2009
Copy link
Contributor

@xiaoxiang781216 @GUIDINGLI How about using a private lock here instead of the global one? cc @masayuki2009

Though I think we should use a private lock as much as possible, let me check this PR with spresense.

To avoid nxsig_alloc_action() & nxsig_release_action() competition

Signed-off-by: ligd <liguiding1@xiaomi.com>
@xiaoxiang781216
Copy link
Contributor

@masayuki2009 do you have any progress?

@masayuki2009
Copy link
Contributor

@masayuki2009 do you have any progress?

I confirmed this PR works with spresense SMP configurations.
But I prefer to use a private spinlock instead of the global one to improve performance.

Copy link
Contributor

@masayuki2009 masayuki2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this PR works with spresense SMP configurations.
But I prefer to use a private spinlock instead of the global one to improve performance.

Let me merge this PR so that I can create a new PR for it.

@masayuki2009 masayuki2009 merged commit 2f55807 into apache:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants