net/tcp/sendfile: removed excessive overwrites of conn->sndseq #5297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-lunev
force-pushed
the
tcp_sendfile_sndseq_control_optimization
branch
from
bf83a13
to
6772557
Compare
(conn->sndseq was updated in multiple places that was unreasonable and complicated). This optimization is the same as it was done for tcp_send_unbuffered.
a-lunev
force-pushed
the
tcp_sendfile_sndseq_control_optimization
branch
from
6772557
to
759219b
Compare
|
Force-pushed to restart as ci issue is fixed. |
xiaoxiang781216
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
conn->sndseq was updated in multiple places that was unreasonable and complicated.
This PR is similar to the corresponding PR for tcp_send_unbuffered (#5102)
Impact
TCP
Testing
Build NuttX:
Enable TUN/TAP on Linux host:
Run netcat server on Linux host:
$ netcat -l -p 31337Run NuttX on Linux host:
Start Wireshark (or tcpdump) and capture appeared tap0 interface.
Run in NuttX:
Observe TCP dump.
Shutdown NuttX:
nsh> poweroffDisable TUN/TAP on Linux host:
$ sudo ./tools/simhostroute.sh wlan0 off