net/tcp(unbuffered): removed excessive overwrites of conn->sndseq #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-lunev
force-pushed
the
sndseq_control_optimization
branch
from
71b44dc
to
059adc6
Compare
(conn->sndseq was updated in multiple places that was unreasonable and complicated).
a-lunev
force-pushed
the
sndseq_control_optimization
branch
from
059adc6
to
e4a71ef
Compare
anchao
approved these changes
Dec 29, 2021
xiaoxiang781216
approved these changes
Dec 29, 2021
|
I noticed this PR has a side effect. Please see the wireshark logs. |
Thank you for letting me know. I was able to reproduce the issue based on ftpc command. As I can see, tcp_sendfile is affected in unbuffered mode. I'm investigating the issue. |
|
@masayuki2009 could you please review and test #5138 for the found issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
conn->sndseq was updated in multiple places that was unreasonable and complicated.
Impact
TCP
Testing