Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/sim: Add adb config for test #5501

Merged
merged 3 commits into from
Mar 5, 2022
Merged

Conversation

xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 commented Feb 15, 2022

Summary

help develop and test adb on sim. Depends on #5545 and #5498

Impact

New config for sim

Testing

Pass CI

Copy link
Contributor

@yamt yamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention it in boards/sim/sim/sim/README.txt?
otherwise lgtm

@xiaoxiang781216
Copy link
Contributor Author

mention it in boards/sim/sim/sim/README.txt? otherwise lgtm

Done.

Copy link
Contributor

@yamt yamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkarashchenko
Copy link
Contributor

Seems that this change depends on #5503

@xiaoxiang781216
Copy link
Contributor Author

Yes, you are right.

@masayuki2009
Copy link
Contributor

@xiaoxiang781216

====================================================================================
Configuration/Tool: sim/adb
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   127  100   127    0     0    920      0 --:--:-- --:--:-- --:--:--   920
From https://github.com/spiriou/microADB
 * branch            b7025c67b866925d1e64c016a844a6a3392557a4 -> FETCH_HEAD

100  711k    0  711k    0     0   797k      0 --:--:-- --:--:-- --:--:--  797k
100 1571k    0 1571k    0     0  1633k      0 --:--:-- --:--:-- --:--:-- 12.0M
/usr/bin/ld: nuttx.rel: in function `adb_uv_on_data_available':
/github/workspace/sources/apps/system/adb/microADB/hal/hal_uv_packet.c:141: undefined reference to `uv_read_stop'
/usr/bin/ld: nuttx.rel: in function `tcp_uv_write':
/github/workspace/sources/apps/system/adb/microADB/hal/hal_uv_client_tcp.c:68: undefined reference to `uv_write'
/usr/bin/ld: nuttx.rel: in function `tcp_uv_kick':
/github/workspace/sources/apps/system/adb/microADB/hal/hal_uv_client_tcp.c:84: undefined reference to `uv_read_start'
/usr/bin/ld: nuttx.rel: in function `tcp_on_connection':
/github/workspace/sources/apps/system/adb/microADB/hal/hal_uv_client_tcp.c:132: undefined reference to `uv_tcp_init'
/usr/bin/ld: /github/workspace/sources/apps/system/adb/microADB/hal/hal_uv_client_tcp.c:139: undefined reference to `uv_accept'
/usr/bin/ld: /github/workspace/sources/apps/system/adb/microADB/hal/hal_uv_client_tcp.c:143: undefined reference to `uv_read_start'
/usr/bin/ld: nuttx.rel: in function `adb_uv_tcp_setup':
/github/workspace/sources/apps/system/adb/microADB/hal/hal_uv_client_tcp.c:161: undefined reference to `uv_tcp_init'
/usr/bin/ld: /github/workspace/sources/apps/system/adb/microADB/hal/hal_uv_client_tcp.c:172: undefined reference to `uv_tcp_bind'
/usr/bin/ld: /github/workspace/sources/apps/system/adb/microADB/hal/hal_uv_client_tcp.c:178: undefined reference to `uv_listen'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:298: nuttx] Error 1
make: *** [tools/Unix.mk:509: nuttx] Error 2
make: Target 'all' not remade because of errors.

@xiaoxiang781216
Copy link
Contributor Author

@masayuki2009 we need new libuv to pass the build. @no1wudi will provide the patch soon.

@no1wudi
Copy link
Contributor

no1wudi commented Feb 24, 2022

Yes, I'll update apache/nuttx-apps#854 tomorrow.

@pkarashchenko
Copy link
Contributor

Please rebase on top of the latest master

…ions

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
mach-o section specifier requires a segment and section separated by a comma

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
Copy link
Contributor Author

@pkarashchenko it's finally pass the build.

@pkarashchenko pkarashchenko merged commit 5659f68 into apache:master Mar 5, 2022
@xiaoxiang781216 xiaoxiang781216 deleted the adb branch March 5, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants